Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix root prefix init #107

Merged
merged 3 commits into from
Jul 23, 2023
Merged

Fix root prefix init #107

merged 3 commits into from
Jul 23, 2023

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented Jul 22, 2023

Since micromamba 1.4.5, mamba-org/mamba#2442 is solved.

@pavelzw pavelzw added the bug Something isn't working label Jul 22, 2023
@pavelzw pavelzw enabled auto-merge (squash) July 22, 2023 23:58
@github-actions github-actions bot added the ci label Jul 22, 2023
@pavelzw pavelzw merged commit 0aaa0e4 into main Jul 23, 2023
@pavelzw pavelzw deleted the root-prefix-init branch July 23, 2023 00:02
@jonashaag
Copy link
Collaborator

This means we can't use old versions of Mamba though

@pavelzw
Copy link
Member Author

pavelzw commented Jul 23, 2023

We could still use versions < 1.4.5 but only with init-shell: none.

@pavelzw
Copy link
Member Author

pavelzw commented Jul 23, 2023

But yes, before we release this version we should probably add a warning or something like that...

@jonashaag
Copy link
Collaborator

It is a breaking change so warrants a major version update. Or we could make the code backwards compatible.

@pavelzw pavelzw mentioned this pull request Jul 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelzw @jonashaag